Set up JS linting for repo#104
Merged
Merged
Conversation
spacedmonkey
commented
Mar 24, 2023
| globals: { | ||
| wp: 'off', | ||
| ajaxurl: 'readonly', | ||
| FormData: 'readonly', |
Member
Author
There was a problem hiding this comment.
When we revisit this, we need to import this correctly.
felixarntz
reviewed
Mar 24, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @spacedmonkey! Mostly looks great, just a few small questions.
spacedmonkey
force-pushed
the
fix/scripts
branch
from
4750c43 to
265a99c
Compare
Member
Author
|
@felixarntz Feedback complete. |
felixarntz
reviewed
Mar 27, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@spacedmonkey Two naming suggestions here, but code-wise looks good.
spacedmonkey
force-pushed
the
fix/scripts
branch
from
444efd0 to
a0e7aff
Compare
jjgrainger
approved these changes
Mar 28, 2023
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @spacedmonkey approved! This will be great to get this merged in today once @felixarntz has approved as this will have a positive impact on the remaining work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
As documented in the WordPress handbook, wp-scripts, as lots of handy linters and checkers. See. Copy and pasted the format npm command in our project and run it. This is the result. Going forward developers can use this command to lint js/md/yml files.
Closes #102
How to test the Change
Changelog Entry
Credits
Props @spacedmonkey
Checklist: