Create Minimal_Theme_Preparation#56
Merged
Merged
Conversation
felixarntz
reviewed
Jan 13, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Mostly looks good. Only one thing to fix in the code I think, but also we should add unit tests.
Merged
felixarntz
reviewed
Jan 13, 2023
felixarntz
reviewed
Jan 13, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Left some feedback on the test class.
felixarntz
reviewed
Jan 16, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Almost good to go now, left 3 small final comments.
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger, Left few final feedback and questions.
felixarntz
reviewed
Jan 18, 2023
mukeshpanchal27
approved these changes
Jan 25, 2023
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger, Only one out standing review #56 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
Minimal_Theme_Preparationclass andwp-empty-themetheme.get_theme_root()method was failing. Looking into this theget_raw_theme_root()function calls theget_theme_roots()function which uses thetheme_rootstransient to search for a valid theme root based on the theme slug. Tests were failing because thetheme_rootstransient wasn't being updated when registering the new theme directory withregister_theme_directory()in the prepare method. I've included asearch_theme_directories( true );function call after registering the theme directory in the prepare method in order to force update this transient.Closes #39