Add Force_Single_Plugin_Preparation class#68
Conversation
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @vishalkakadiya overall looking good, but left some minor feedback.
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
|
Thank you! @jjgrainger @felixarntz It is ready for your review now. Thank you! |
|
@jjgrainger I have addressed your feedback, can you re-review it again. Thank you! 🙂 |
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @vishalkakadiya approved!
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya This is going in the right direction. There are a few quirks with the production logic that need to be ironed out, but otherwise just suggestions to enhance the tests and a few nit-picks.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
|
@felixarntz I have addressed your feedback and left one comment, you can do the second round of review now. Thank you! |
vishalkakadiya
requested review from
jjgrainger
and removed request for
jjgrainger
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya Almost good to go. One follow up point from my previous review that wasn't fully addressed, and two very small nit-picks - they wouldn't be blocking, but since the one test feedback needs to be addressed anyway, it would be great if you could address those two small things as well.
|
@felixarntz I have addressed the remaining feedback on it. It is ready for review now. Thank you! |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya Pretty much LGTM, just 3 nit-picks that would be good to address. Feel free to merge afterwards without another review.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
|
@felixarntz Thank you for the feedback, I have fixed those and merging this now. |
vishalkakadiya
deleted the
feature/add-force-single-plugin-preparation
branch
3 participants
Adds the Force_Single_Plugin_Preparation class
Closes #58