Add Universal_Runtime_Preparation class#69
Merged
Conversation
added 2 commits
February 6, 2023 11:04
…re/add-universal-runtime-preparation
vishalkakadiya
changed the base branch from
trunk
to
feature/add-force-single-plugin-preparation
added 2 commits
February 6, 2023 11:18
…re/add-universal-runtime-preparation
felixarntz
requested changes
Feb 6, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya There are a few small things to fix here before we can merge this. Also the test can be simplified, since the detailed testing already happens for the two classes used within this class.
Base automatically changed from
feature/add-force-single-plugin-preparation
to
trunk
February 7, 2023 05:19
Author
|
@felixarntz I have addressed all the feedback here, you can review it now. Thanks! |
jjgrainger
approved these changes
Feb 7, 2023
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @vishalkakadiya approved
felixarntz
approved these changes
Feb 7, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thank you for the updates @vishalkakadiya, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Universal_Runtime_Preparation class
Closes #61