Skip to content

Register the TOTP QR generation script on the front-end.#495

Merged
dd32 merged 1 commit into
WordPress:masterfrom
dd32:fix/totp-on-front-end
Nov 18, 2022
Merged

Register the TOTP QR generation script on the front-end.#495
dd32 merged 1 commit into
WordPress:masterfrom
dd32:fix/totp-on-front-end

Conversation

@dd32
Copy link
Copy Markdown
Member

@dd32 dd32 commented Nov 17, 2022

This allows for the renderer to enqueue the TOTP generation on the front-end - Such as within the bbPress settings panel.

Without this, the JS is never loaded and you just see a spinner.

See 70ba42e & #487

This allows for the renderer to enqueue the TOTP generation on the front-end (Such as within the bbPress settings panel)
Copy link
Copy Markdown
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@dd32 dd32 merged commit 43f2e4f into WordPress:master Nov 18, 2022
@jeffpaul jeffpaul added this to the 0.8.0 milestone Nov 18, 2022
@lkraav
Copy link
Copy Markdown

lkraav commented Dec 14, 2022

Does this help #189?

We're also looking for an alternate solution for iThemes 2FA that has zero frontend management.

@iandunn
Copy link
Copy Markdown
Member

iandunn commented Dec 15, 2022

It should, yeah. #504 will probably also help with that. There may be more that's needed, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants