Skip to content

Add information about where to submit security bugs#541

Merged
peterwilsoncc merged 1 commit into
WordPress:masterfrom
felixarntz:add/faq-security-pointer
Mar 16, 2023
Merged

Add information about where to submit security bugs#541
peterwilsoncc merged 1 commit into
WordPress:masterfrom
felixarntz:add/faq-security-pointer

Conversation

@felixarntz
Copy link
Copy Markdown
Member

What?

This adds an FAQ entry for where to file security bugs.

Why?

Per request from the WordPress security team.

How?

The copy used is similar to the one that is already present here in the Gutenberg SECURITY.md file, which was used as a reference.

Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix, much appreciated.

@peterwilsoncc peterwilsoncc merged commit c0eae28 into WordPress:master Mar 16, 2023
@iandunn
Copy link
Copy Markdown
Member

iandunn commented Mar 17, 2023

Thanks! #481 also added a SECURITY.md, but in .github/ instead of /:

https://github.com/WordPress/two-factor/blob/c0eae28ce5c83d28bdf810dc940f33febe38a0b7/SECURITY.md

https://github.com/WordPress/two-factor/blob/c0eae28ce5c83d28bdf810dc940f33febe38a0b7/.github/SECURITY.md

It sounds like GH supports both locations. I personally prefer .github to reduce clutter, but if all our other repos are using / then the consistency is probably more important.

Any other opinions on which one we should delete?

@jeffpaul jeffpaul added this to the 0.8.0 milestone Mar 17, 2023
@felixarntz
Copy link
Copy Markdown
Member Author

felixarntz commented Mar 17, 2023

@iandunn Apologies, I wasn't aware of that.

I think having SECURITY.md in the root helps visibility. I have to admit, I didn't even know that GitHub actually does something with these files, and I have never paid attention to see that there's a Security tab on those repos that uses the security policy from that file. 🤦

That may just be me, but maybe other people too. That's why I would personally argue it should be in the root, for better visibility. Furthermore it's common to have other "similar" files like CONTRIBUTING.md at the root level too.

@felixarntz felixarntz removed their assignment Mar 17, 2023
@iandunn
Copy link
Copy Markdown
Member

iandunn commented Mar 17, 2023

That WFM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants