Skip to content

add phpcs:ignore for falsepositives #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasparsd merged 2 commits into from
Feb 2, 2026
Merged

add phpcs:ignore for falsepositives #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d06387
fix phpcs warning
masteradhoc Feb 1, 2026
881e5da
phpcs ignore
masteradhoc Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions class-two-factor-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,7 @@ public static function _login_form_validate_2fa( $user, $nonce = '', $provider =
if ( true !== $result ) {
$error = '';
if ( is_wp_error( $result ) ) {
do_action( 'wp_login_failed', $user->user_login, $result );
do_action( 'wp_login_failed', $user->user_login, $result ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress action.

$error = $result->get_error_message();
}
Expand Down Expand Up @@ -1509,7 +1509,7 @@ public static function _login_form_validate_2fa( $user, $nonce = '', $provider =
</div>
<?php
/** This action is documented in wp-login.php */
do_action( 'login_footer' );
do_action( 'login_footer' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress action.
?>
<?php if ( $customize_login ) : ?>
<script type="text/javascript">setTimeout( function(){ new wp.customize.Messenger({ url: '<?php echo esc_url( wp_customize_url() ); ?>', channel: 'login' }).send('login') }, 1000 );</script>
Expand All @@ -1519,7 +1519,7 @@ public static function _login_form_validate_2fa( $user, $nonce = '', $provider =
return;
}

$redirect_to = apply_filters( 'login_redirect', $redirect_to, $redirect_to, $user );
$redirect_to = apply_filters( 'login_redirect', $redirect_to, $redirect_to, $user ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress filter.
wp_safe_redirect( $redirect_to );
}

Expand Down Expand Up @@ -1577,7 +1577,7 @@ public static function _login_form_revalidate_2fa( $nonce = '', $provider = '',
if ( true !== $result ) {
$error = '';
if ( is_wp_error( $result ) ) {
do_action( 'wp_login_failed', $user->user_login, $result );
do_action( 'wp_login_failed', $user->user_login, $result ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress action.

$error = $result->get_error_message();
}
Expand Down Expand Up @@ -1610,14 +1610,14 @@ public static function _login_form_revalidate_2fa( $nonce = '', $provider = '',
</div>
<?php
/** This action is documented in wp-login.php */
do_action( 'login_footer' );
do_action( 'login_footer' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress action.
?>
</body></html>
<?php
return;
}

$redirect_to = apply_filters( 'login_redirect', $redirect_to, $redirect_to, $user );
$redirect_to = apply_filters( 'login_redirect', $redirect_to, $redirect_to, $user ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Core WordPress filter.
wp_safe_redirect( $redirect_to );
return;
}
Expand Down Expand Up @@ -1939,7 +1939,7 @@ public static function user_two_factor_options( $user ) {
*
* @since 0.1-dev
*/
do_action( 'show_user_security_settings', $user, $providers );
do_action( 'show_user_security_settings', $user, $providers ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Legacy unprefixed hook.
}

/**
Expand Down
2 changes: 1 addition & 1 deletion providers/class-two-factor-fido-u2f-admin-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public function inline_edit() {
}

/** This action is documented in wp-admin/includes/class-wp-posts-list-table.php */
do_action( 'quick_edit_custom_box', $column_name, 'edit-security-keys' );
do_action( 'quick_edit_custom_box', $column_name, 'edit-security-keys' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
}
?>
<p class="inline-edit-save submit">
Expand Down