Skip to content

Admin: Standardize mobile viewport heights for interactive elements on list table pages #11461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SainathPoojary wants to merge 5 commits into
base: trunk
Choose a base branch
from
+57 −4
Open

Admin: Standardize mobile viewport heights for interactive elements on list table pages #11461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fac703a
Administration: Standardize Screen Options and Help button heights in…
SainathPoojary Apr 7, 2026
81c1592
Administration: Standardize Tablenav elements heights in mobile viewp…
SainathPoojary Apr 7, 2026
4576131
Administration: Standardize pagination heights in mobile viewport.
SainathPoojary Apr 7, 2026
6a588bc
Merge branch 'trunk' into fix/64999
SainathPoojary Apr 8, 2026
f6a9d5c
Merge branch 'trunk' into fix/64999
t-hamano May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/wp-admin/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4284,6 +4284,16 @@ img {
margin-bottom: 20px; /* Add margins beneath links for better spacing between boxes and elements */
}

#screen-meta-links .show-settings {
box-sizing: border-box;
min-height: 40px;
line-height: 2.71428571;
}

#screen-meta-links .show-settings:after {
font: normal 20px/1.9 dashicons;
}

Comment on lines +4287 to +4296
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#screen-meta-links .show-settings {
box-sizing: border-box;
min-height: 40px;
line-height: 2.71428571;
}
#screen-meta-links .show-settings:after {
font: normal 20px/1.9 dashicons;
}

I think we should use the button-compact class instead of hardcoding override styles in the mobile layout. This button is 32px in size and will automatically scale to 40px in the mobile layout.

wordpress-develop/src/wp-includes/css/buttons.css

Line 383 in 8a99228

.wp-core-ui .button.button-compact,

Therefore, simply adding button-compact to the following locations should resolve the issue.

wordpress-develop/src/wp-admin/includes/class-wp-screen.php

Line 972 in 8a99228

<button type="button" id="show-settings-link" class="button show-settings" aria-controls="screen-options-wrap" aria-expanded="false"><?php _e( 'Screen Options' ); ?></button>

wordpress-develop/src/wp-admin/includes/class-wp-screen.php

Line 979 in 8a99228

<button type="button" id="contextual-help-link" class="button show-settings" aria-controls="contextual-help-wrap" aria-expanded="false"><?php _e( 'Help' ); ?></button>

.wp-filter .search-form input[type="search"] {
font-size: 1rem;
}
Expand Down
42 changes: 42 additions & 0 deletions src/wp-admin/css/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,6 +1757,42 @@ table.form-table td .updated p {
display: block;
}

.wp-core-ui .tablenav input[type="text"],
.wp-core-ui .tablenav input[type="password"],
.wp-core-ui .tablenav input[type="date"],
.wp-core-ui .tablenav input[type="datetime"],
.wp-core-ui .tablenav input[type="datetime-local"],
.wp-core-ui .tablenav input[type="email"],
.wp-core-ui .tablenav input[type="month"],
.wp-core-ui .tablenav input[type="number"],
.wp-core-ui .tablenav input[type="search"],
.wp-core-ui .tablenav input[type="tel"],
.wp-core-ui .tablenav input[type="time"],
.wp-core-ui .tablenav input[type="url"],
.wp-core-ui .tablenav input[type="week"],
.wp-core-ui .tablenav select {
min-height: 40px;
}

.wp-core-ui .tablenav select {
line-height: 2.375;
font-size: 16px;
}
Comment on lines +1777 to +1780
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these styles really necessary?


#doaction,
#doaction2,
#post-query-submit {
min-height: 40px;
line-height: 2.71428571;
padding: 0 14px;
}
Comment on lines +1782 to +1788
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid such overwrites, I believe we should remove min-height, line-height, and padding from these buttons in the first place:

wordpress-develop/src/wp-admin/css/forms.css

Lines 521 to 528 in 8a99228

#doaction,
#doaction2,
#post-query-submit {
margin: 0 8px 0 0;
min-height: 32px;
line-height: 2.30769231; /* 30px for 32px height with 13px font */
padding: 0 12px;
}

Instead, we should be able to use button-compact class.


.wp-core-ui .tablenav .button {
min-height: 40px;
line-height: 2.71428571;
padding: 0 14px;
}

p.search-box {
float: none;
width: 100%;
Expand All @@ -1775,6 +1811,12 @@ table.form-table td .updated p {
margin-bottom: 0;
}

p.search-box .button {
min-height: 40px;
line-height: 2.71428571; /* 38px - matches default mobile button */
padding: 0 14px;
}
Comment on lines +1814 to +1818
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to use the button-compact class instead.

Additionally, the height of the text field needs to be changed from 32px to 40px.

Image


p.search-box input[type="submit"] {
margin-bottom: 10px;
}
Expand Down
9 changes: 5 additions & 4 deletions src/wp-admin/css/list-tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,15 +1957,16 @@ div.action-links,

.tablenav .tablenav-pages .button,
.tablenav .tablenav-pages .tablenav-pages-navspan {
min-width: 44px;
padding: 12px 8px;
min-width: 40px;
min-height: 40px;
padding: 10px 8px;
font-size: 18px;
line-height: 1;
}

.tablenav-pages .pagination-links .current-page {
min-width: 44px;
padding: 12px 6px;
min-width: 40px;
padding: 10px 6px;
font-size: 16px;
line-height: 1.125;
}
Expand Down
Loading