Skip to content

#47280 - Remove SQL_CALC_FOUND_ROWS and lazy load found_rows #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnbillion wants to merge 82 commits into from
Closed

#47280 - Remove SQL_CALC_FOUND_ROWS and lazy load found_rows #2119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
76e09be
Remove usage of deprecated MySQL SQL_CALC_FOUND_ROWS
morgo Jun 8, 2020
12ac2d4
Merge branch 'trunk' into rm-sql-calc-found-rows
johnbillion Jan 6, 2022
a6648d8
Add ticket references.
johnbillion Jan 6, 2022
1a16fc3
Docs.
johnbillion Jan 6, 2022
43a8da5
Todos.
johnbillion Jan 6, 2022
0b98da8
More docs.
johnbillion Jan 6, 2022
d62ae5f
First pass at lazy loading the `found_posts` and `max_num_pages` prop…
johnbillion Jan 6, 2022
69a5dd8
Ensure repeated calls to the `found_posts` or `max_num_pages` propert…
johnbillion Jan 6, 2022
c25537d
Extra queries are generated when term and meta caches are updated.
johnbillion Jan 6, 2022
acc3f1f
Add some extra bytes to keep the computer happy.
johnbillion Jan 6, 2022
ea95d46
No need to repeat this twice.
johnbillion Jan 10, 2022
87a2755
Move all this into a data provider.
johnbillion Jan 10, 2022
1ec9bf7
Docs.
johnbillion Jan 10, 2022
9dfbc37
Add tests that ensure the newly private properties are publicly acces…
johnbillion Jan 11, 2022
74c117e
This is a private method so its signature can be safely changed.
johnbillion Jan 11, 2022
9a8be54
Whoops.
johnbillion Jan 11, 2022
48ebdd5
Keep the coding standards bot happy.
johnbillion Jan 11, 2022
d111d93
Another whoops.
johnbillion Jan 11, 2022
7bc9130
Introduce a dedicated and simpler tests for testing the accuracy of p…
johnbillion Jan 11, 2022
ef72499
Ensure the count properties can be read by `isset()`.
johnbillion Jan 11, 2022
6ebca81
More tests, remove the data provider.
johnbillion Jan 11, 2022
c5d974c
More assertions.
johnbillion Jan 12, 2022
c95af1f
Correct the post counts for term queries.
johnbillion Jan 12, 2022
5a89980
Test paged queries.
johnbillion Jan 12, 2022
dd03845
Test meta queries.
johnbillion Jan 12, 2022
457f708
Remove some duplication.
johnbillion Jan 12, 2022
e2a1990
More coverage for `no_found_rows` values.
johnbillion Jan 12, 2022
620c392
Coding standards.
johnbillion Jan 12, 2022
af26641
Ensure there are no errors and the counts are correct for empty queries.
johnbillion Jan 12, 2022
a3c968d
Add tests for queries with no limits or paging.
johnbillion Jan 12, 2022
d74745b
Run all the relevant tests with each of the available `fields` args.
johnbillion Jan 12, 2022
22095a1
Support PHP and JSON serialization.
johnbillion Jan 12, 2022
64e6363
Be more specific about this guard condition.
johnbillion Jan 12, 2022
9408909
Coding standards.
johnbillion Jan 12, 2022
92059b3
Implement serialization in a way that's compatible with PHP 5.6 to 8.1.
johnbillion Jan 12, 2022
262ad2e
Ignore PHPCS warnings about the magic serialization methods.
johnbillion Jan 12, 2022
70316e1
Add a test for a filter on `posts_request` that uses `SQL_CALC_FOUND_…
johnbillion Jan 12, 2022
cc927ee
Add back compat in case anything uses the `posts_request` filter and …
johnbillion Jan 12, 2022
d27629b
Trigger a deprecated notice when a filter on `posts_request` returns …
johnbillion Jan 12, 2022
492caf5
Boop.
johnbillion Jan 12, 2022
e8a4634
Merge branch 'trunk' into 47280
johnbillion Jan 19, 2022
1c3df82
Add an explicit assertion for `FOUND_ROWS()`.
johnbillion Jan 19, 2022
759e8d8
Add a test for switching sites between the query and fetching the pos…
johnbillion Jan 20, 2022
ceec5ff
Coding standards.
johnbillion Jan 20, 2022
26174be
Add more tests for `no_found_rows`.
johnbillion Jan 20, 2022
02f4270
Merge branch 'trunk' into 47280
johnbillion Jan 28, 2022
241f805
Allow the `found_posts` and `max_num_pages` properties to be set exte…
johnbillion Jan 28, 2022
1ab6b3a
Rename this for clarity.
johnbillion Jan 29, 2022
3a67678
Apply some basic formatting to SQL queries during a test failure.
johnbillion Jan 30, 2022
dd323a7
Add a test for queries that trigger the `post_status_join` branch.
johnbillion Jan 30, 2022
656a371
Syntax correction.
johnbillion Jan 30, 2022
d92e64c
Merge branch 'trunk' into 47280
johnbillion Mar 28, 2022
0a7325d
Re-remove `SQL_CALC_FOUND_ROWS`.
johnbillion Mar 28, 2022
32e9bd3
Apply suggestions from code review
johnbillion Mar 28, 2022
f24cb97
Rename the fields data provider.
johnbillion Mar 28, 2022
49b195a
Use static closures.
johnbillion Mar 28, 2022
85cba24
Docs!
johnbillion Mar 28, 2022
6ed6430
Add a test for multiple meta queries.
johnbillion Mar 29, 2022
2e2ccf7
Formatting.
johnbillion Mar 29, 2022
b78e97b
Implement the deprecated argument message for the `posts_request` fil…
johnbillion Apr 2, 2022
36bc0a6
More docs.
johnbillion Apr 2, 2022
146dc6b
Add a test that covers no results.
johnbillion Apr 2, 2022
6ff250e
Add a test that covers the value of the count properties when `no_fou…
johnbillion Apr 2, 2022
46e7466
Better naming.
johnbillion Apr 2, 2022
212e629
Add tests that cover fetching found rows before serialization.
johnbillion Apr 2, 2022
b4e0e5a
¯\_(ツ)_/¯
johnbillion Apr 2, 2022
df1db9d
Revert changes in other query classes for now to keep the `WP_Query` …
johnbillion Apr 2, 2022
e7623ed
More docs.
johnbillion Apr 2, 2022
994d3f7
Merge branch 'trunk' into 47280
johnbillion May 8, 2022
fc7cca4
Merge branch 'trunk' into 47280
johnbillion Jun 23, 2022
3041fde
More tidying up of SQL in test failure messages.
johnbillion Jun 23, 2022
0f0abb0
Merge branch 'trunk' into 47280
johnbillion Jun 23, 2022
02754ab
Merge branch 'trunk' into 47280
johnbillion Jul 3, 2022
5ad1aff
This can be null too.
johnbillion Jul 3, 2022
3d8d30e
Merge branch 'trunk' into 47280
johnbillion Aug 14, 2022
47f5c6f
Always count distinct post IDs. This ensures the count for meta queri…
johnbillion Aug 14, 2022
b9bddc4
Account for a custom `GROUP BY` field or fields.
johnbillion Aug 14, 2022
abe2176
Coding standards.
johnbillion Aug 14, 2022
bbedca0
My coding is not up to standards.
johnbillion Aug 14, 2022
7df4894
Merge branch 'trunk' into 47280
spacedmonkey Oct 3, 2022
98e4ff3
Merge branch 'trunk' into 47280
johnbillion Jan 17, 2023
d537eab
Avoid a deprecated error in PHP 8.1.
johnbillion Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading