Regenerate PHP packages in the sync-gutenberg-packages task #2679
Closed
adamziel wants to merge 5 commits into
Closed
Regenerate PHP packages in the sync-gutenberg-packages task #2679adamziel wants to merge 5 commits into
adamziel wants to merge 5 commits into
Conversation
…the build task before build:dev
gziolo
reviewed
May 5, 2022
adamziel
force-pushed
the
update/sync-gutenberg-packages-to-rebuild-php-includes
branch
from
848ba38 to
6156242
Compare
gziolo
reviewed
May 10, 2022
| * https://core.trac.wordpress.org/ticket/55559 | ||
| */ | ||
| const distTag = grunt.option('dist-tag') || 'latest'; | ||
| const currentBranch = spawn( 'git', [ 'branch', '--show-current' ], { |
Member
There was a problem hiding this comment.
It won't work for svn users 😅
However, I think it's very unlikely you would run latest outside of the trunk branch.
Contributor
Author
There was a problem hiding this comment.
Let's not block this PR on that and move this discussion to a separate one
Member
Contributor
Author
|
Fantastic! Let's close this PR then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
npx sync-gutenberg-packagescommand introduced in #2621 does not regenerate thescript-loader-packages.phpfile.This PR makes it run
npm run buildto regenerate that file.Let's test it on Tuesday when releasing RC2 @gziolo