Backport: Navigation Post Preloading in Site Editor#4628
Conversation
audrasjb
left a comment
audrasjb
left a comment
There was a problem hiding this comment.
I left a small feedback concerning a small docblock issue :)
|
@getdave This new file needs to be loaded in wp-settings.php |
|
Understood. My first time doing backports. Let me get this sorted. |
@getdave See my feedback on trac ticket before continuing. |
|
Preload paths for Navigation have now be inlined directly in the Site Editor file as per recommendations. |
| 'per_page' => 100, | ||
| 'order' => 'desc', | ||
| 'orderby' => 'date', | ||
| '_locale' => 'user', |
There was a problem hiding this comment.
The javascript should be refactored so this rest api call is not made twice.
There was a problem hiding this comment.
Agreed. We're tracking it in WordPress/gutenberg#51803
|
Not sure what's going on with the CI tests here. I believe I now wait for a Core Committer to merge this? |
Yes! If @tellthemachines can't get to it today, hopefully someone will sweep in tonight and commit. Thanks again! |
5 participants
Adds a
navigation.phpfile to hold all hooks/utilites relating to Navigation in the Block Editor.Backports over the preloading hook for Navigation Posts.
Trac ticket: https://core.trac.wordpress.org/ticket/58556
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.