-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Editor: Make asset registration .asset.php optional for blocks #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
josephfusco
wants to merge
22
commits into
WordPress:trunk
from
josephfusco:asset.php-unnecessary-doing-it-wrong
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
837931e
Gracefully handle scenarios where *.asset.php is absent
josephfusco 36d3af1
Add test coverage
josephfusco 1142150
Linting issues
josephfusco 511c6f1
Correct linting issue
josephfusco 5c67d33
Remove _doing_it_wrong check
josephfusco f3fad9e
Remove early return
josephfusco 21c52a5
Reduce complexities
josephfusco 7219bde
Test for return of expected handle
josephfusco c9d758b
Resolve whitespace linting issues
josephfusco 610a40a
Update tests
josephfusco 543274b
Fix unit test failures
gziolo 0847e7d
Update tests/phpunit/tests/blocks/register.php
gziolo 5c4bb72
Delete tests/phpunit/data/blocks/no-asset-php/block-rtl.css
gziolo 081e4fc
Delete tests/phpunit/data/blocks/no-asset-php/block.json
gziolo 9af46c5
Delete tests/phpunit/data/blocks/no-asset-php/render.php
gziolo ffd38f9
Delete tests/phpunit/data/blocks/no-asset-php/block.js
gziolo 2f16a53
Delete tests/phpunit/data/blocks/no-asset-php/block.css
gziolo 8cfe4fc
Update src/wp-includes/blocks.php
gziolo 267f49c
Update register.php
gziolo c000be1
Fix the failures reported for PHP 8
gziolo e362c64
Update blocks.php
gziolo c3edb3d
Update blocks.php
gziolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.