Tests: expand hooks priority tests to further check call order for happy and unhappy paths#5841
Closed
hellofromtonya wants to merge 5 commits into
Closed
Conversation
0ea126e to
3e50d6b
Compare
f6fdb0c to
fdae408
Compare
Adds (2) dataProviders for each path. Reworks the test to validate the call order for both.
fdae408 to
c491384
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Contributor
Author
|
Committed via https://core.trac.wordpress.org/changeset/57257. |
|
Another alternative to #5811 and #5835. Uses some code from #5609. Good idea, but it’s more of a workaround than a full solution.
Best direction:
Implements an idea originally conceived of in https://core.trac.wordpress.org/ticket/60193: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the existing tests for hooks priority tests to futher check the call order for happy (numeric priorities) and unhappy (non-numeric priorities) paths.
Call order tests added to:
do_action()WP_Hook::do_action()apply_filters()WP_Hook::apply_filters()The tests are redundant, yes, but necessary to test at least functional level, given there's different logic in each of these functions.
Trac ticket: https://core.trac.wordpress.org/ticket/60193
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.