Conversation
adamsilverstein
force-pushed
the
ticket/39941b
branch
from
ab55dce to
76c2fc9
Compare
|
In general this seems fine, except the comment about the attribute names. That said, it would be good to see these changes in the context of where the functions will be used, eg. in the script loader tags, CSP-protected inline JS, etc. |
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
…develop-fork into ticket/39941b
# Conflicts: # src/wp-includes/functions.php
@johnbillion I addressed your feedback here. In terms of how these will be used, take a look at https://core.trac.wordpress.org/ticket/39941 / #498) and https://core.trac.wordpress.org/ticket/51407 / #551 which are the follow up issues created to actually use this new API. |
# Conflicts: # src/wp-includes/functions.php
|
Closed with changeset https://core.trac.wordpress.org/changeset/50167 |
4 participants
Trac ticket: https://core.trac.wordpress.org/ticket/39941
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.