Support profile - move security settings onto separate screen

[iandunn]

WIP

Fixes WordPress/wporg-two-factor#26

Regular Profile:

Forum Profile

[iandunn]

@dd32, @pkevan, @tellyworth : this pr creates a new https://wordpress.org/support/users/{username}/edit/account/ page. that works in conjunction with the ui-stub branch in wporg-two-factor, which renders the wporg-two-factor/settings block into new page. that block would use REST API requests like Dion is building in WordPress/two-factor#504 to save the 2FA settings, and Core users endpoint to save email/password/language.

the text is just rough stubs and there's no design, but take a look at the code for both branches and let me know if you think this is a good architecture to build on

[pkevan]

I'm not deeply familiar with the profiles part, but seems like a sensible way to approach this initially.

[iandunn]

I've committed the parts that we can deploy now in 4db5f38 and r19711-dotorg, so now the branch just has the parts that need to wait until we launch everything for users.

[StevenDufresne]

I think we may need another path to security settings.

Logged in, when I click "Edit Profile", I land on https://profiles.wordpress.org/{username}/profile/edit/ which doesn't have any references to security settings. I would have to already know the settings is in our "Forum profiles".

Should we add a section to the General tab that leads directly to 2fa?

I'm not sure if that's the best language or link treatment :).

[pkevan]

We probably also want to change the label/link in the Forum profile from Edit Account to be more descriptive too

[iandunn]

change the label/link in the Forum profile from Edit Account to be more descriptive too

🤔 Do you have any ideas? It was named "Account" because previously the email/password settings were in a section of the profile page named "Account"

Renaming it to "Security" makes sense for the 2FA settings, but I don't think users would expect that for email. Maybe "Account Settings" instead of "Edit Account" ?

[iandunn]

Should we add a section to the General tab that leads directly to 2fa?

What do you think about this?

That way we include "Security", with might catch folks eyes while they're scanning, but it still has "password" and "two-factor authentication". I'm also open to having a sections for each, though.

[StevenDufresne]

Yeah, that looks good to me.

[pkevan]

change the label/link in the Forum profile from Edit Account to be more descriptive too

🤔 Do you have any ideas? It was named "Account" because previously the email/password settings were in a section of the profile page named "Account"

Renaming it to "Security" makes sense for the 2FA settings, but I don't think users would expect that for email. Maybe "Account Settings" instead of "Edit Account" ?

It's just labelled Security on WP.com, although I agree it's somewhat confusing when it contains email, although don't think it's a big issue - might be good for consistency.

[iandunn]

🤔 Changing the menu label would also entail changing the rewrite rule and links to the page.

I don't personally think it's worth it, but I'm not opposed to it either. I'd rather not tack that onto this PR, though, do you mind opening another issue for it?