Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 27 27
Lines 609 613 +4
Branches 57 61 +4
=====================================
+ Hits 609 613 +4
Continue to review full report at Codecov.
|
bojdell
reviewed
Mar 20, 2017
|
|
||
| /** | ||
| * Generic trait wrapping Elasticsearch alias information. | ||
| */ |
Contributor
There was a problem hiding this comment.
I'd personally prefer to avoid naming things with Genericand instead add 1_7 or 5 in the class names for the version-specific implementations.
Contributor
|
FYI took a quick pass at addressing my comment here: https://github.com/Workday/escalar/tree/issue-4-bo-wip , although it's still a WIP. I'll commit/merge it onto this PR when it's ready |
Contributor
Author
|
Awesome, I'll have the afternoon free tmrw and Thursday to take a look as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for making escalar more extensible for temporary ES5 support.