Skip to content

Clear staging directory before deploying artifacts #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomnis merged 3 commits into from
Jul 24, 2025
Merged

Clear staging directory before deploying artifacts #118

tomnis merged 3 commits into from
Jul 24, 2025

Conversation

@tomnis
Copy link
Contributor

@tomnis tomnis commented Jul 22, 2025

  • for publishing, make sure the build staging directory only contains artifacts from a fresh run
  • put eager logger initialization into an object instead of a trait

@tomnis tomnis requested review from jonathanpmao and rooeque July 23, 2025 17:06
jonathanpmao
jonathanpmao approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@jonathanpmao jonathanpmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomnis tomnis merged commit 0883e4a into master Jul 24, 2025
12 checks passed
@tomnis tomnis deleted the gatling-upgrade-feature branch July 24, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpmao jonathanpmao jonathanpmao approved these changes

@rooeque rooeque Awaiting requested review from rooeque

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomnis @jonathanpmao