Merged
Conversation
pierrevalade
commented
Feb 5, 2025
added 2 commits
February 5, 2025 14:11
- all the examples are now in examples/ folder, numbered - all assets are in examples/assets - update examples/README
Contributor
Author
|
@guillaq ready for a first review! lots of changes, trying to add more documentation to make our SDK easier to understand with real-life examples. thanks! |
guillaq
approved these changes
Feb 5, 2025
guillaq
previously approved these changes
Feb 5, 2025
Contributor
Author
|
@guillaq thanks for the feedback, ready for another review! |
guillaq
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guillaq I'm running into this error:
The linter (Ruff) is warning about a naming issue in your code. Specifically, it's showing error code
A002which means you're usinginputas a parameter name, butinputis actually a built-in Python function.In Python,
input()is a built-in function used to get user input from the console. When you useinputas a parameter name:You're "shadowing" (hiding) the built-in
input()function within the scope of your function. This is generally considered bad practice because:input()function within your function's scopeTo fix this, you should rename the parameter to something more specific, like:
city_inputrequestquerywhat do you think?