Skip to content

Create 14_templated_instructions.py#49

Merged
guillaq merged 8 commits intomainfrom
pierre-example-instruction-variables
Feb 18, 2025
Merged

Create 14_templated_instructions.py#49
guillaq merged 8 commits intomainfrom
pierre-example-instruction-variables

Conversation

@pierrevalade
Copy link
Contributor

adds an example on how to use variables in instructions -- works well! 👍

adds an example on how to use variables in instructions
@pierrevalade pierrevalade requested a review from guillaq February 10, 2025 12:47
@pierrevalade pierrevalade changed the title Create 13_templated_instructions.py Create 14_templated_instructions.py Feb 10, 2025
@pierrevalade
Copy link
Contributor Author

@guillaq ready for review, thanks!

guillaq
guillaq previously approved these changes Feb 10, 2025
guillaq
guillaq previously approved these changes Feb 13, 2025
@pierrevalade
Copy link
Contributor Author

@guillaq looks like ruff check are failing in the CI, but not locally.

.venvpierrevalade@Pierres-MacBook-Air workflowai-py % poetry run ruff check .
All checks passed!

any idea? thanks!

@guillaq
Copy link
Collaborator

guillaq commented Feb 14, 2025

I think the version of ruff you have installed is not the same as the version in the poetry.lock. make install should fix !

We could add a check that the dependencies are correct in the pre-commit hook

@pierrevalade pierrevalade requested a review from guillaq February 14, 2025 15:32
@pierrevalade
Copy link
Contributor Author

ok, thank you @guillaq -- ready for final review.

guillaq
guillaq previously approved these changes Feb 17, 2025
@pierrevalade pierrevalade requested a review from guillaq February 17, 2025 16:34
@pierrevalade
Copy link
Contributor Author

ready for final review @guillaq

@guillaq
Copy link
Collaborator

guillaq commented Feb 18, 2025

I looks like these changes are included in https://github.com/WorkflowAI/workflowai-py/pull/50/files but the commit hashes don't match ?

@pierrevalade
Copy link
Contributor Author

I looks like these changes are included in https://github.com/WorkflowAI/workflowai-py/pull/50/files but the commit hashes don't match ?

sorry, my mistake, I've removed the changes from examples/14_templated_instructions.py from the https://github.com/WorkflowAI/workflowai-py/pull/50/files PR.

@pierrevalade
Copy link
Contributor Author

so @guillaq ready again, thanks!

@guillaq guillaq merged commit e5968f1 into main Feb 18, 2025
5 checks passed
@guillaq guillaq deleted the pierre-example-instruction-variables branch February 18, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants