Skip to content

Examples: text to sql, multi consensus#50

Merged
guillaq merged 16 commits intomainfrom
pierre-examples-text-to-sql-multi-consensus
Feb 18, 2025
Merged

Examples: text to sql, multi consensus#50
guillaq merged 16 commits intomainfrom
pierre-examples-text-to-sql-multi-consensus

Conversation

@pierrevalade
Copy link
Contributor

adds two examples.

@pierrevalade pierrevalade requested a review from guillaq February 10, 2025 13:30
@pierrevalade pierrevalade marked this pull request as ready for review February 10, 2025 13:33
@pierrevalade
Copy link
Contributor Author

@guillaq ready for review, thanks!

@pierrevalade pierrevalade changed the base branch from main to pierre-example-instruction-variables February 10, 2025 13:34
@pierrevalade
Copy link
Contributor Author

@guillaq I have a error in the lint check I'm not sure about --- could you please check? thanks!

Copy link
Contributor Author

@guillaq ready for another review, thanks!

@guillaq
Copy link
Collaborator

guillaq commented Feb 12, 2025

@pierrevalade pyright does not like async def analyze_call_feedback(input: CallFeedbackInput, *, model: Model) ->

See #50 (comment)

@pierrevalade pierrevalade requested a review from guillaq February 14, 2025 01:08
@pierrevalade
Copy link
Contributor Author

thank you @guillaq -- ready for another review.

Copy link
Contributor Author

@guillaq i will let you fix this branch, i'm getting stuck too much, thanks.

@pierrevalade pierrevalade changed the base branch from pierre-example-instruction-variables to main February 14, 2025 15:52
@pierrevalade pierrevalade requested a review from guillaq February 14, 2025 16:00
@pierrevalade
Copy link
Contributor Author

@guillaq ready for another review, thanks!

guillaq
guillaq previously approved these changes Feb 18, 2025
Copy link
Collaborator

@guillaq guillaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@guillaq guillaq changed the base branch from main to pierre-example-instruction-variables February 18, 2025 14:43
@guillaq guillaq changed the base branch from pierre-example-instruction-variables to main February 18, 2025 14:43
@guillaq guillaq dismissed their stale review February 18, 2025 14:43

The base branch was changed.

@pierrevalade
Copy link
Contributor Author

@guillaq could you please review again? thanks!

Remove examples/14_templated_instructions.py from PR
@guillaq guillaq merged commit ae9f084 into main Feb 18, 2025
5 checks passed
@guillaq guillaq deleted the pierre-examples-text-to-sql-multi-consensus branch February 18, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants