Merged
Conversation
pierrevalade
commented
Feb 12, 2025
Fix in examples/01_basic_agent.py:\n- Replace incorrect runCityInput(city="Tokyo")) call\n- Use correct run(CityInput(city="Tokyo")) method\n- Remove extra closing parenthesis
Contributor
Author
|
@guillaq ready for another review, thanks! |
added 3 commits
February 17, 2025 11:47
Add example #15 demonstrating PII extraction and redaction with: - 10 PII categories (NAME, EMAIL, PHONE, etc.) - Structured output with redacted text and extracted PII details - Position tracking for each PII instance - Comprehensive examples covering basic and complex PII scenarios
Simplify the RAG chatbot example (examples/13_rag.py):\n- Remove conversation_history management from ChatInput\n- Remove Role enum and Message base class\n- Simplify AssistantMessage to standalone model\n- Update agent return type (ChatbotOutput instead of Run[ChatbotOutput])\n- Add more comprehensive examples using .reply for conversation flow\n- Keep RAG functionality with search_faq tool unchanged
Break long line into multiple lines in examples/11_ecommerce_chatbot.py to comply with line length limit
guillaq
previously approved these changes
Feb 18, 2025
Collaborator
guillaq
left a comment
guillaq
left a comment
There was a problem hiding this comment.
You prefer calling .run than the agent function directly ?
feat(examples): add PII extraction example
…xamples Use reply for chatbot examples
Contributor
Author
|
yes, i think |
Contributor
Author
|
what do you think? |
guillaq
approved these changes
Feb 18, 2025
Collaborator
guillaq
left a comment
guillaq
left a comment
There was a problem hiding this comment.
Yeah I think that if you need the full run object then .run is clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll open as a draft PR to ask questions.