feat(models): add ModelInfo and list_models functionality#57
Merged
Conversation
Add ModelInfo class to represent detailed model information including metadata like provider, pricing, and capabilities. Implement list_models method on Agent class to fetch available models with their full details. Changes: - Add ModelMetadata and ModelInfo classes with comprehensive model attributes - Implement list_models() method on Agent class - Add unit tests for model listing functionality - Update agent test fixtures with new model info structure
guillaq
reviewed
Feb 18, 2025
Collaborator
guillaq
left a comment
guillaq
left a comment
There was a problem hiding this comment.
Nice ! A test needs fixed but all good otherwise
guillaq
reviewed
Feb 18, 2025
…age[T] class for consistent pagination responses - Update ListModelsResponse to inherit from Page[ModelInfo] - Fix type checking error in agent_test.py with proper null check - Remove redundant count field from ListModelsResponse
Contributor
Author
|
@guillaq ready for re-review, thank you! |
guillaq
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ModelInfo class to represent detailed model information including metadata like provider, pricing, and capabilities. Implement list_models method on Agent class to fetch available models with their full details.
Changes: - Add ModelMetadata and ModelInfo classes with comprehensive model attributes - Implement list_models() method on Agent class - Add unit tests for model listing functionality - Update agent test fixtures with new model info structure