Conversation
guillaq
reviewed
Feb 26, 2025
Collaborator
guillaq
left a comment
guillaq
left a comment
There was a problem hiding this comment.
Could you also add the function to the _AgentBase protocol for typing ? (sorry it was not there before)
Contributor
Author
|
Thanks for the review. I'll adjust tomorrow |
…ructions-and-requires_tools-to
Co-authored-by: guillaq <guillaume@workflowai.com>
yannbu
commented
Feb 27, 2025
|
|
||
| class _AgentBase(Protocol, Generic[AgentOutput]): | ||
| # TODO: fix circular dep | ||
| from workflowai.core.client._models import ModelInfo |
Contributor
Author
There was a problem hiding this comment.
@guillaq I can rollback the _AgentBase too.
Collaborator
There was a problem hiding this comment.
ah that sucks, it breaks the layering I guess since the domain is not meant to import the client.
Yeah let's rollback. Sorry I didn't think about it !
Contributor
Author
guillaq
approved these changes
Feb 27, 2025
|
|
||
| class _AgentBase(Protocol, Generic[AgentOutput]): | ||
| # TODO: fix circular dep | ||
| from workflowai.core.client._models import ModelInfo |
Collaborator
There was a problem hiding this comment.
ah that sucks, it breaks the layering I guess since the domain is not meant to import the client.
Yeah let's rollback. Sorry I didn't think about it !
Collaborator
|
Ah never mind. Let's merge now and we will fix later. |
guillaq
deleted the
yann/wor-3802-have-list_models-pass-the-instructions-and-requires_tools-to
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/workflowai/issue/WOR-3802/have-list-models-pass-the-instructions-and-requires-tools-to-the-api