Skip to content

Conversation

@emxsys
Copy link
Member

@emxsys emxsys commented Apr 13, 2019

Description of the Change

Changed the javadoc text to produce an error and warning free build of the community edition WorldWindJava API documentation. Also changed the API documentation branding to reflect the community edition.

Online API branding:

  • Browser window/tab title: WorldWindJava API
  • Document title on JavaDoc overview: NASA WorldWind Java-Community Edition
  • Headers on JavaDoc pages: NASA WorldWind-CE
  • Previews values were "NASA WorldWind" for all the above.

Why Should This Be In Core?

Part of an error free build.

Benefits

  • Reduces the noise in the build output.
  • May be required for Maven or Gradle builds.

Potential Drawbacks

None

Applicable Issues

Closes #16

emxsys added 2 commits April 13, 2019 11:17
- Window title as it appears in a browser tab changed to "WorldWindJava API".
- JavaDoc document title on overview page changed to "NASA WorldWind Java-Community Edition"
- JavaDoc headers at top of docs changed to "NASA WorldWind-CE"
- Previous values were "NASA WorldWind" for all.
@emxsys emxsys requested a review from wcmatthysen April 13, 2019 18:33
@emxsys emxsys added the bug Something isn't working label Apr 13, 2019
Copy link
Member

@wcmatthysen wcmatthysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I scanned the javadoc fixes that you made and it looks good. It is basically the same what I had in mind.

@wcmatthysen wcmatthysen merged commit 9039b48 into WorldWindEarth:develop Apr 13, 2019
@emxsys emxsys self-assigned this Apr 13, 2019
@wcmatthysen wcmatthysen added this to the WWJ-CE 2.2.0 milestone Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix javadoc errors in build

2 participants