Wrong implementation of `ListHandlers` in `inbound.go`

[mostafa3dmax]

Integrity requirements

• I confirm that I have read the documentation, understand the meaning of all the configuration items I wrote, and did not pile up seemingly useful options or default values.
• I provided the complete config and logs, rather than just providing the truncated parts based on my own judgment.
• I searched issues and did not find any similar issues.
• The problem can be successfully reproduced in the latest Release

Description

Bug Report: Wrong implementation of ListHandlers in inbound.go

In app/proxyman/inbound/inbound.go, the ListHandlers method has an incorrect usage of the copy function.

Currently, it is written as:

copy(m.untaggedHandler, response)

However, this does not copy anything into response, because response is nil at that point.

It should be:

response := make([]inbound.Handler, len(m.untaggedHandler))
copy(response, m.untaggedHandler)

Without this fix, ListHandlers returns an empty list even when untaggedHandler is populated.

Thanks!

Reproduction Method

response := make([]inbound.Handler, len(m.untaggedHandler))
copy(response, m.untaggedHandler)

Client config

Details

Server config

Details

Client log

Details

Server log

Details

[Fangliding]

func (m *Manager) ListHandlers(ctx context.Context) []inbound.Handler {
	m.access.RLock()
	defer m.access.RUnlock()

	var response []inbound.Handler
	copy(m.untaggedHandler, response)

	for _, v := range m.taggedHandlers {
		response = append(response, v)
	}

	return response
}

copy操作似乎没有任何影响 完全是多余的 response 是零长 执行copy压根不会修改 然后返回response是通过后面的遍历加上的

@gsergey418

[patterniha]

It should be:

response := make([]inbound.Handler, len(m.untaggedHandler))
copy(response, m.untaggedHandler)

This is obvious, so why doesn't anyone fix it?

[RPRX]

@patterniha 你开 PR 吧

[Fangliding]

It should be:

response := make([]inbound.Handler, len(m.untaggedHandler))
copy(response, m.untaggedHandler)

This is obvious, so why doesn't anyone fix it?

等回复而已 不过好像并没有看到