-
Notifications
You must be signed in to change notification settings - Fork 4.9k
common/buf/multi_buffer.go: Fix Compact() #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: patterniha <71074308+patterniha@users.noreply.github.com>
|
Thanks @Fangliding I've test this branch and it does fix the #5012 👍 However, I can still logging like this: |
|
|
|
My code is full-compact, but your code is optimized-compact. So your code doesn't compact some data. For example your code doesn't merge the first data into second data in: So, your code may send some small packets at beginning of the protocol, and this create a unique-characteristic that GFW can recognized. |
协议最开始的部分都是new出来空buf 你告诉我怎么compact出若干小包?这个函数就是尽力而为将碎片buf合并而已 目的是效率 如果真要硬能合多少合多少那应该是readall才对 |
This comment was marked as resolved.
This comment was marked as resolved.
|
bug修了就行 这没啥意义还难看 能是什么指纹 这都是用户产生的数据 |
|
Fixes XTLS#5012 Co-authored-by: patterniha <71074308+patterniha@users.noreply.github.com>
#5014
之前的bug写成test case了