Skip to content

Conversation

@Fangliding
Copy link
Member

#5014

之前的bug写成test case了

Co-authored-by: patterniha <71074308+patterniha@users.noreply.github.com>
@Vdu6n1XMrq6694a8
Copy link

Thanks @Fangliding

I've test this branch and it does fix the #5012 👍

However, I can still logging like this:

[Info] [3437932928] app/proxyman/inbound: connection ends > proxy/vmess/inbound: connection ends > proxy/vmess/inbound: failed to transfer request > websocket: close 1000 (normal)

@patterniha
Copy link
Collaborator

10 hours non-stop debugging to find this bug

@patterniha
Copy link
Collaborator

@Fangliding

My code is full-compact, but your code is optimized-compact.

So your code doesn't compact some data.

For example your code doesn't merge the first data into second data in:
[8190,8192], [0, 1000], [0, 1000], ...

So, your code may send some small packets at beginning of the protocol, and this create a unique-characteristic that GFW can recognized.

@Fangliding
Copy link
Member Author

Fangliding commented Aug 11, 2025

@Fangliding

My code is full-compact, but your code is optimized-compact.

So your code doesn't compact some data.

For example your code doesn't merge the first data into second data in: [8190,8192], [0, 1000], [0, 1000], ...

So, your code may send some small packets at beginning of the protocol, and this create a unique-characteristic that GFW can recognized.

协议最开始的部分都是new出来空buf 你告诉我怎么compact出若干小包?这个函数就是尽力而为将碎片buf合并而已 目的是效率 如果真要硬能合多少合多少那应该是readall才对

@patterniha

This comment was marked as resolved.

@Fangliding
Copy link
Member Author

Fangliding commented Aug 11, 2025

bug修了就行 这没啥意义还难看 能是什么指纹 这都是用户产生的数据

@patterniha
Copy link
Collaborator

10 hours non-stop debugging to find this bug

after fixing about 30 bugs and at least 5 major bugs, and adding many features finally @Fangliding liked my comment :)

@RPRX RPRX changed the title Fix compact common/buf/multi_buffer.go: Fix Compact() Aug 15, 2025
@RPRX RPRX merged commit f3cdcad into main Aug 15, 2025
159 of 160 checks passed
@RPRX RPRX deleted the compact branch August 15, 2025 15:29
Jolymmiles pushed a commit to Jolymmiles/Xray-core that referenced this pull request Aug 15, 2025
Fixes XTLS#5012

Co-authored-by: patterniha <71074308+patterniha@users.noreply.github.com>
maoxikun pushed a commit to maoxikun/Xray-core that referenced this pull request Aug 23, 2025
Fixes XTLS#5012

Co-authored-by: patterniha <71074308+patterniha@users.noreply.github.com>
(cherry picked from commit f3cdcad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants