-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Abstract the WrapLink method to Dispatcher interface #5286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
好好说话我看到会reopen的 我甚至之前看你还开了一个这第三个了都 然后调用自己的WrapLink |
Contributor
Author
|
大佬,我这里再改一下嘛? return w.Dispatcher.WrapLink(ctx, link) |
Member
|
它们本来也没人call啊 |
Contributor
Author
|
那添加这个的作用是什么? return w.Dispatcher.WrapLink(ctx, link) |
Member
|
因为这样noop摆着不好 要声明出接口起码让它有作用 |
Contributor
Author
|
要不我加点注释吧,防止以后维护不明确? |
Member
|
就按我说的有问题吗这种类wrapper不都是这么写的 |
Contributor
Author
|
稍等这就去改 |
Contributor
Author
|
已经改好了,您review一下 |
Member
|
你这。。。 |
Contributor
|
@Fangliding 这个问题不抱希望了 |
Member
|
还是我来写吧 不太能沟通 |
Contributor
|
实际需求是#5133 |
RPRX
pushed a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
需要将 WrapLink 方法抽取到 Dispatcher 接口
因为 Custom 的 DefaultDispatcher 注入到 Xray-core 会出现:
所以需要抽象接口,之前的设计都是接口,感觉这个属于设计缺陷