Optimize pipe #5467
Open
Optimize pipe #5467
+18
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
加入了测试结果：好像这个版本把 mux 关掉的话反而慢了 download 313 Mbits/sec upload 325 Mbits/sec |
Member
Author
|
之前断言失败的性能提升应该是来自pipe |
Member
|
这个可以合了吗 |
Member
Author
|
yuhan说性能会开倒车 还得缓缓 |
Fangliding
force-pushed
the
optimize-pipe
branch
from
7dc1c4f to
d5f17ab
Compare
Member
Author
|
我滚了一下 pipe本身是没啥问题的 应该可以合 主要是后面发现的那个gather io的问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这样可以解决 #5409 (comment) 提到的所有问题了 但是有点丑 如果套一层reader就炸了(