Align device identifiers with game #42
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current language of the game allows the following types for devices in instructions:
d#)r#)???)The current code base does not understand the concept of a device ID at all so I've added a minimal concept of it. It also does not accept a register as a valid input for a device-related instruction despite the in-game documentation saying it's allowed (as a pointer to which device to access).
Screenshot of the in-game documentation showing registers as an acceptable input for devices:
Screenshot of the LSP in action inside of the amazing awilliamson/ic10-language-support VSCode extension: