Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Feb 12, 2019

Similar to how InvoicesEndpoint has an Ids method to find multiple
Invoices at the same time, this method is for retrieving multiple
contacts at the same time which helps with batching requests and not
hitting the API request limit as quickly when fetching a lot of data, and I've added a unit test for completeness.

Similar to how InvoicesEndpoint has an Ids method to find multiple
Invoices at the same time, this method is for retreiving multiple
contacts at the same time which helps with batching requests and not
hitting the API request limit as quickly when fetching a lot of data.

Also added a unit test method for listing by ids and that passes.
@ghost
Copy link
Author

ghost commented Feb 12, 2019

I've added this PR because when using the Xero Api wrapper I found that there wasn't an option to pull multiple contacts at the same time but the API itself supported it so I thought it would be a useful thing to have in the api wrapper if this gets merged.

@ghost ghost closed this Feb 12, 2019
@ghost ghost reopened this Feb 12, 2019
@DerekHAu
Copy link

DerekHAu commented Sep 9, 2019

any word on this being merged?

@MJMortimer MJMortimer merged commit 493c1bb into XeroAPI:master Apr 27, 2020
@MJMortimer
Copy link
Contributor

Thanks for your contribution @DerekHAu, apologies for the delay

@ghost
Copy link
Author

ghost commented Apr 27, 2020

Thanks @MJMortimer! Any idea roughly when there would be a new release available on nuget with the merged changes? No rush, just curious

@MJMortimer
Copy link
Contributor

Within the next hour 🤞

@ghost ghost deleted the f-contacts-multiple branch April 29, 2020 14:50
@ghost ghost restored the f-contacts-multiple branch April 29, 2020 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants