This repository was archived by the owner on Apr 12, 2021. It is now read-only.
While condition is always true the second time #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the `while` to an `if` because the previous implementation would always return `false` the second time that condition was checked. The queue is dequeued with each enqueue and all the properties involved are private, so it's safe to assume the condition only needs to be checked once. Note, this is not thread safe, but RateLimiter already is not thread safe (XeroAPI#248).
Contributor
|
By the same logic, you can change the >= to just be == |
Contributor
|
Thanks for this @MrOnosa, sorry for the delay in merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the
whileto anifbecause the previous implementation would always returnfalsethe second time that condition was checked. The queue is dequeued with each enqueue and all the properties involved are private, so it's safe to assume the condition only needs to be checked once. Note, this is not thread safe, but RateLimiter already is not thread safe (#248).