F nolog4js #59
Merged
F nolog4js #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Awesome. Can't wait to test and merge. Is this a breaking change? |
Contributor
Author
|
@jordanwalsh23 Excellent. It will be a breaking change for anyone who is depending on the logging. But as far as I can tell there was no way to configure logging via the config passed into xero-node. So I think that it was always just logging to stout anyway. I'm hoping that no one is dependent. The early days are the ones to make theses changes. See #52 for some of my thoughts on future. |
…nolog4js # Conflicts: # docs/Sample-App-Setup.md # sample_app/index.js
Contributor
Author
|
@jordanwalsh23 uptodate with master and green locally Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes log4js.
I removed it and copied into my node_modues to see if it resolved my webpack issues. It did. And tests are green locally.