axi_ethernet: fix DT gen in "PCS/PMA" mode #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the xxv_ethernet is configured in "Ethernet PCS/PMA 64-bit" mode, there can be no IPs connected to its RX and TX interfaces. This commit prevents that the variable `connected_ip` remains undefined and subsequent errors because of this.
|
This patch seems to have fixed the issues we've been seeing related to building devicetrees. Before it's merged we can't use our CI/CD to build the networking part of our system. |
Author
|
@acetylen out of curiosity, are you allowed to share how the 10/25G Ethernet IP is connected? |
|
@j-marjanovic Sure, here's a block diagram. xxv_ethernet block is in the bottom right.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the xxv_ethernet is configured in "Ethernet PCS/PMA 64-bit" mode,
there can be no IPs connected to its RX and TX interfaces.
This commit prevents that the variable
connected_ipremains undefinedand subsequent errors because of this.