Fix HLS MVAU/VVAU threshold datatype minimization#1561
Merged
Conversation
… case to verify fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the threshold datatype could be minimized narrower than the accumulator datatype in HLS MVAU and VVAU, causing incorrect results when accumulator values exceed the threshold type's range.
The HLS implementation uses the threshold datatype for comparisons. When
MinimizeWeightBitWidth()reduced threshold dtype to a narrower type than the accumulator (e.g., INT8 thresholds vs INT14 accumulator), accumulator values were truncated during comparison, producing wrong outputs.Changes
matrixvectoractivation.py/vectorvectoractivation.py: Removed threshold minimization logic from base classes (RTL variants don't support embedded thresholds)matrixvectoractivation_hls.py/vectorvectoractivation_hls.py: Addedminimize_weight_bit_width() override that:test_fpgadataflow_mvau.py: Added test case with small thresholds and extreme inputs to verify the fix