core, eth, miner: 4844 blob transaction pool #26940 #1911

gzliudan · 2026-01-05T08:33:04Z

Proposed changes

Ref: ethereum#26940

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)
Regular KTLO or any of the maintaince work. e.g code style
CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
Tested the backwards compatibility.
Tested with XDC nodes running this version co-exist with those running the previous version.
Relevant documentation has been updated as part of this PR
N/A

coderabbitai · 2026-01-05T08:33:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR integrates EIP-4844 blob transaction pool functionality by introducing a modular transaction pool architecture with specialized subpools. The main changes include refactoring the legacy transaction pool into a subpool implementation and creating a new aggregator pool that manages multiple transaction type-specific subpools.

Key changes:

Introduced SubPool interface and LazyTransaction wrapper for deferred transaction resolution
Refactored existing transaction pool code from txpool package to legacypool package
Created new aggregator TxPool that manages multiple subpools and routes transactions accordingly

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
miner/worker.go	Updated to use LazyTransaction wrapper and new ordering functions
miner/ordering_test.go	Added comprehensive tests for transaction ordering with lazy loading
miner/ordering.go	Implemented new transaction ordering logic with miner fee calculations
core/txpool/txpool.go	Replaced legacy pool with new aggregator pool managing subpools
core/txpool/subpool.go	Defined SubPool interface and LazyTransaction structure
core/txpool/errors.go	Extracted error definitions to shared package
core/txpool/validation.go	Added UsedAndLeftSlots validation callback
core/txpool/txpool_test.go	Moved and updated tests to legacypool package
eth/backend.go	Updated to instantiate new modular pool architecture
Multiple files	Package renames from `txpool` to `legacypool`

Comments suppressed due to low confidence (1)

miner/ordering.go:1

Corrected 'if' to 'it' for grammatical accuracy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/txpool/validation.go

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-22T02:20:29Z

miner/ordering.go

+	for from, accTxs := range txs {
+		var normalTxs []*txpool.LazyTransaction
+		for _, lazyTx := range accTxs {
+			if tx := lazyTx.Resolve(); tx.Tx.IsSpecialTransaction() {


Potential nil pointer dereference: lazyTx.Resolve() can return nil, and then accessing tx.Tx.IsSpecialTransaction() will panic. The code should check if tx is nil before accessing tx.Tx.

Suggested change

if tx := lazyTx.Resolve(); tx.Tx.IsSpecialTransaction() {

tx := lazyTx.Resolve()

if tx == nil {

// Skip entries that failed to resolve to a concrete transaction

continue

}

if tx.Tx.IsSpecialTransaction() {

core/txpool/legacypool/legacypool.go

miner/ordering.go

core/txpool/legacypool/legacypool.go

Copilot · 2026-01-22T02:20:30Z

miner/ordering_test.go

+	txset, _ := newTransactionsByPriceAndNonce(signer, groups, map[common.Address]*big.Int{}, baseFee)
+
+	txs := types.Transactions{}
+	for tx := txset.Peek(); tx != nil; tx = txset.Peek() {


Potential nil pointer dereference: tx.Tx could be nil if Resolve() returns a non-nil wrapper but with nil Tx field. The code should check if tx.Tx is not nil before accessing tx.Tx.Tx.

Suggested change

for tx := txset.Peek(); tx != nil; tx = txset.Peek() {

for tx := txset.Peek(); tx != nil; tx = txset.Peek() {

if tx.Tx == nil || tx.Tx.Tx == nil {

t.Fatalf("unexpected nil transaction in txset")

}

Copilot · 2026-01-22T02:20:30Z

miner/ordering_test.go

+	txset, _ := newTransactionsByPriceAndNonce(signer, groups, map[common.Address]*big.Int{}, nil)
+
+	txs := types.Transactions{}
+	for tx := txset.Peek(); tx != nil; tx = txset.Peek() {


Potential nil pointer dereference: tx.Tx could be nil if Peek() returns a LazyTransaction with nil Tx field. The code should check if tx.Tx is not nil before accessing tx.Tx.Tx.

Suggested change

for tx := txset.Peek(); tx != nil; tx = txset.Peek() {

for tx := txset.Peek(); tx != nil; tx = txset.Peek() {

if tx.Tx == nil || tx.Tx.Tx == nil {

t.Fatalf("unexpected nil transaction in txset")

}

Copilot · 2026-01-22T02:20:30Z

miner/worker.go

-
+		warped := lazyTx.Resolve()
+		if warped == nil || warped.Tx == nil {
+			break


Potential nil pointer dereference: if lazyTx.Resolve() returns a non-nil wrapper but with tx.Tx being nil, the code breaks. However, when warped is nil or warped.Tx is nil, the function breaks out of the loop. This could prematurely terminate transaction processing when there might be more valid transactions in the queue. Consider calling txs.Shift() or txs.Pop() instead of breaking, to move past the invalid transaction and continue processing other transactions.

Suggested change

break

log.Warn("Skipping invalid transaction wrapper")

txs.Pop()

continue

Copilot AI review requested due to automatic review settings January 5, 2026 08:33

Copilot started reviewing on behalf of gzliudan January 5, 2026 08:33 View session

gzliudan requested review from AnilChinchawale, anunay-xin, benjamin202410, liam-lai and wanwiset25 January 5, 2026 08:33

Copilot AI reviewed Jan 5, 2026

View reviewed changes

core/txpool/validation.go Show resolved Hide resolved

gzliudan force-pushed the blob-txpool branch from d4a51f4 to 681699f Compare January 5, 2026 10:38

anunay-xin approved these changes Jan 8, 2026

View reviewed changes

benjamin202410 approved these changes Jan 13, 2026

View reviewed changes

gzliudan force-pushed the blob-txpool branch 2 times, most recently from 6a8b8ca to 04746b4 Compare January 16, 2026 11:46

AnilChinchawale approved these changes Jan 16, 2026

View reviewed changes

wanwiset25 approved these changes Jan 18, 2026

View reviewed changes

core, eth, miner: 4844 blob transaction pool ethereum#26940

be8b933

gzliudan force-pushed the blob-txpool branch from 04746b4 to be8b933 Compare January 19, 2026 05:02

AnilChinchawale merged commit 3e1f75e into XinFinOrg:dev-upgrade Jan 19, 2026
13 checks passed

gzliudan deleted the blob-txpool branch January 19, 2026 06:20

gzliudan requested a review from Copilot January 22, 2026 02:15

Copilot started reviewing on behalf of gzliudan January 22, 2026 02:16 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

This was referenced Jan 22, 2026

error: "pool attempted to unreserve non-reserved address" #1975

Closed

txpool: make unreserve idempotent to avoid false non-reserved errors, fix #1975 #1976

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core, eth, miner: 4844 blob transaction pool #26940 #1911

core, eth, miner: 4844 blob transaction pool #26940 #1911

Uh oh!

gzliudan commented Jan 5, 2026

Uh oh!

coderabbitai bot commented Jan 5, 2026 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Copilot AI Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

-			if tx := lazyTx.Resolve(); tx.Tx.IsSpecialTransaction() {
+			tx := lazyTx.Resolve()
+			if tx == nil {
+				// Skip entries that failed to resolve to a concrete transaction
+				continue
+			}
+			if tx.Tx.IsSpecialTransaction() {

-			break
+			log.Warn("Skipping invalid transaction wrapper")
+			txs.Pop()
+			continue

core, eth, miner: 4844 blob transaction pool #26940 #1911

core, eth, miner: 4844 blob transaction pool #26940 #1911

Uh oh!

Conversation

gzliudan commented Jan 5, 2026

Proposed changes

Types of changes

Impacted Components

Checklist

Uh oh!

coderabbitai bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Jan 5, 2026 •

edited

Loading