Fix plan constraints to support rotated geometries#17
Conversation
Replaced the conservative AABB check in `PlanLoader.ApplyConstraints` with a two-stage process: 1. Fast check using `plan.Bounds` (AABB). 2. Precise check verifying that all individual geometries are covered by the bounding polygon. This resolves an issue where rotated plans were incorrectly rejected because their axis-aligned bounding box exceeded the lot boundaries, even if the plan itself fit perfectly. Also exposed `ResPlan.Library` internals to `ResPlan.Tests` to allow testing the validation logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Replaced the conservative AABB check in `PlanLoader.ApplyConstraints` with a two-stage process: 1. Fast check using `plan.Bounds` (AABB). 2. Precise check verifying that all individual geometries are covered by the bounding polygon. This resolves an issue where rotated plans were incorrectly rejected because their axis-aligned bounding box exceeded the lot boundaries, even if the plan itself fit perfectly. Also exposed `ResPlan.Library` internals to `ResPlan.Tests` to allow testing the validation logic.
1 participant
Improved plan constraint checking logic to correctly handle rotated plans. Previously, the system used
plan.Bounds(Axis-Aligned Bounding Box) for containment checks, which would fail for plans rotated to fit diagonal lots. The new implementation falls back to a precise geometry check if the AABB check fails.PR created automatically by Jules for task 13704174550045896890 started by @Xyrces