Library: don't crash at exit after a folder or a comic is deleted #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finished() signal of both FoldersRemover and ComicsRemover was not connected to their QThread's quit() slot. So the thread kept running after the deletion completed. The QThread's parent is LibraryWindow. Thus LibraryWindow's ~QObject() invokes the QThread's destructor. As a result, when the user exited YACReader Library after deleting at least one folder or comic, it printed the following FATAL message and crashed at exit: "QThread: Destroyed while thread is still running". Extract signal-slot connections between a remover and a QThread into moveAndConnectRemoverToThread() to reduce code duplication. Remove always true (thread != NULL) checks.
QSqlDatabase::commit() in ComicModel::finishTransaction() returned false (failed) when this slot was invoked the second time in a row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.