Consolidate CLI Adapters into Controller Registry#5
Conversation
Migrates domain-specific CLI subcommands from hardcoded dispatch in `core/cli.rs` to a registry-based system in `core/all.rs`. - Moves `agent_cli.rs` to `openhuman/agent/cli.rs`. - Moves `memory_cli.rs` to `openhuman/memory/cli.rs`. - Registers all domain CLI adapters (`agent`, `memory`, `text-input`, `tree-summarizer`, `screen-intelligence`) in `cli_adapters()`. - Adds underscore aliases for multi-word namespaces for better registry dispatch. - Cleans up `core/cli.rs` and `core/mod.rs` to remove hardcoded domain logic. Closes tinyhumansai#688. Co-authored-by: YellowSnnowmann <167776381+YellowSnnowmann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Migrates domain-specific CLI subcommands from hardcoded dispatch in `core/cli.rs` to a registry-based system in `core/all.rs`. - Moves `agent_cli.rs` to `openhuman/agent/cli.rs`. - Moves `memory_cli.rs` to `openhuman/memory/cli.rs`. - Registers all domain CLI adapters (`agent`, `memory`, `text-input`, `tree-summarizer`, `screen-intelligence`) in `cli_adapters()`. - Adds underscore aliases for multi-word namespaces for better registry dispatch. - Cleans up `core/cli.rs` and `core/mod.rs` to remove hardcoded domain logic. - Fixes formatting and module ordering for CI. Closes tinyhumansai#688. Co-authored-by: YellowSnnowmann <167776381+YellowSnnowmann@users.noreply.github.com>
1 participant
Migrated domain-specific CLI subcommands (
agent,memory,text-input,tree-summarizer,screen-intelligence) from hardcoded match arms insrc/core/cli.rsto a centralized registry insrc/core/all.rs. Relocated the implementation files to their respective domain modules undersrc/openhuman/. This refactoring aligns with the project rule of exposing domain functionality via the controller registry and keeping the transport layer generic. Added underscore-based aliases for multi-word namespaces to ensure compatibility with the generic namespace dispatcher. verified withcargo check,cargo test, and manual CLI smoke tests.PR created automatically by Jules for task 6193887378871393447 started by @YellowSnnowmann