Skip to content

Simplify get_activation_factory #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YexuanXiao merged 1 commit into from
Mar 14, 2026
Merged

Simplify get_activation_factory #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions cppwinrt/component_writers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ namespace cppwinrt
if (settings.component_opt)
{
auto format = R"(
if (requal(name, L"%.%"))
if (name == L"%.%"sv)
{
return winrt_make_%();
}
Expand All @@ -120,7 +120,7 @@ namespace cppwinrt
else
{
auto format = R"(
if (requal(name, L"%.%"))
if (name == L"%.%"sv)
{
return winrt::detach_abi(winrt::make<winrt::@::factory_implementation::%>());
}
Expand Down Expand Up @@ -151,11 +151,7 @@ bool __stdcall %_can_unload_now() noexcept

void* __stdcall %_get_activation_factory([[maybe_unused]] std::wstring_view const& name)
{
auto requal = [](std::wstring_view const& left, std::wstring_view const& right) noexcept
{
return std::equal(left.rbegin(), left.rend(), right.rbegin(), right.rend());
};
%
using namespace std::string_view_literals;%
return nullptr;
}
)";
Expand Down