Update dependency socket.io to v3 - autoclosed#1158
Closed
mend-for-github-com[bot] wants to merge 1 commit intomasterfrom
Closed
Update dependency socket.io to v3 - autoclosed#1158mend-for-github-com[bot] wants to merge 1 commit intomasterfrom
mend-for-github-com[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^2.1.0->^3.0.0By merging this PR, the below vulnerabilities will be automatically resolved:
Release Notes
socketio/socket.io
v3.0.0Compare Source
Bug Fixes
Features
BREAKING CHANGES
the Socket#use() method is removed (see 5c73733)
Socket#join() and Socket#leave() do not accept a callback argument anymore.
Before:
After:
Before:
The 'origins' option was used in the allowRequest method, in order to
determine whether the request should pass or not. And the Engine.IO
server would implicitly add the necessary Access-Control-Allow-xxx
headers.
After:
The already existing 'allowRequest' option can be used for validation:
Socket#rooms is now a Set instead of an object
Namespace#connected is now a Map instead of an object
there is no more implicit connection to the default namespace:
This method was kept for backward-compatibility with pre-1.0 versions.
v2.4.1Compare Source
This release reverts the breaking change introduced in
2.4.0(socketio/socket.io@f78a575).If you are using Socket.IO v2, you should explicitly allow/disallow cross-origin requests:
In any case, please consider upgrading to Socket.IO v3, where this security issue is now fixed (CORS is disabled by default).
Reverts
Links:
~3.5.0~7.4.2v2.4.0Compare Source
Related blog post: https://socket.io/blog/socket-io-2-4-0/
Features (from Engine.IO)
Bug Fixes
Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (
Access-Control-Allow-xxx) to any domain. This will not be the case anymore, and you now have to explicitly enable it.Please note that you are not impacted if:
originsoption to restrict the list of allowed domainsThis commit also removes the support for '*' matchers and protocol-less URL:
To restore the previous behavior (please use with caution):
See also:
Thanks a lot to @ni8walk3r for the security report.
Links:
~3.5.0~7.4.2v2.3.0Compare Source
This release mainly contains a bump of the
engine.ioandwspackages, but no additional features.Links:
~3.4.0(diff: socketio/engine.io@3.3.1...3.4.2)^7.1.2(diff: websockets/ws@6.1.2...7.3.1)v2.2.0Compare Source
Features
Bug fixes
Links
~3.3.1(diff: socketio/engine.io@3.2.0...3.3.1)~6.1.0(diff: websockets/ws@3.3.1...6.1.2)v2.1.1Compare Source
Features
Bug fixes
(client) fire an error event on middleware failure for non-root namespace (socketio/socket.io-client#1202)
Links:
~3.2.0~3.3.1