Merged
Conversation
Contributor
PR Checks complete
Created with Flutter code quality action |
Contributor
|
Visit the preview URL for this PR (updated for commit 53d3c8d): https://zds-c9c24--pr-88-ux-1386-2-dwixzw0w.web.app (expires Mon, 16 Jun 2025 13:20:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9e05e2ffbf7f11b6305259262f782e751f182319 |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to Flutter 3.32.x, adapts new color APIs for opacity handling, and refreshes example project dependencies and configuration.
- Migrate all
Color.withOpacity(...)calls to the newColor.withValues(alpha: ...)API. - Remove redundant
asyncmodifiers and add explicit type annotations where appropriate. - Update example’s
pubspec.yaml, workflows, and FVM config to align with Flutter 3.32.x.
Reviewed Changes
Copilot reviewed 67 out of 67 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/components/molecules/input_dialog.dart | Removed unnecessary async on onTap callback |
| lib/src/components/molecules/dropdown.dart | Replaced withOpacity with withValues(alpha: …) |
| lib/src/components/molecules/date_range_picker.dart | Dropped async from showZdsDateRangePicker, updated DialogTheme type, and migrated opacity calls |
| lib/src/components/molecules/bottom_sheet.dart | Refactored border opacity using withValues(alpha: …) |
| lib/src/components/atoms/speed_slider.dart | Added explicit type for defaultItems and parameterized GlobalKey |
| lib/src/components/atoms/selection_pills.dart | Migrated withOpacity to withValues(alpha: …) |
| lib/src/components/atoms/icon_text_button.dart | Updated box shadow color using withValues(alpha: …) |
| lib/src/components/atoms/expandable.dart | Added dynamic parameter type to _afterLayout and migrated opacity |
| lib/src/components/atoms/button.dart | Updated overlay color calculation to use withValues(alpha: …) |
| example/pubspec.yaml | Bumped dependency versions, switched several deps to any, and added dependency_overrides |
| example/macos/Runner/AppDelegate.swift | Added applicationSupportsSecureRestorableState override |
| example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme | Enabled GPU validation mode |
| example/macos/Flutter/GeneratedPluginRegistrant.swift | Renamed import and registration for the Record plugin to record_macos |
| example/lib/pages/components/expansion_tile.dart | Replaced withOpacity with withValues(alpha: …) for titleColor |
| example/.gitignore | Added .build/ and .swiftpm/ |
| analysis_options.yaml | Ignored unsafe_variance analyzer error |
| .github/workflows/pull-request.yml | Updated Flutter version to 3.32.x |
| .github/workflows/on-release.yml | Updated Flutter version to 3.32.x |
| .github/workflows/on-main.yml | Updated Flutter version to 3.32.x |
| .fvmrc | Added Flutter SDK pin (3.32.2) for FVM |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DE7924
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.