Conversation
Contributor
PR Checks complete
Created with Flutter code quality action |
…ality improvements - Refactored action buttons to include disabled state and semantic labels. - Implemented disabled state for ZetaMessageInput, affecting all action buttons and input fields. - Improved test coverage for message input component, including accessibility and interaction tests. - Updated widgetbook examples to reflect new properties and functionality.
Contributor
|
Visit the preview URL for this PR (updated for commit 92ba34e): https://zeta-flutter-main--pr-384-ux-1501-voxans6c.web.app (expires Fri, 26 Sep 2025 14:48:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
Collaborator
thelukewalton
left a comment
There was a problem hiding this comment.
Need to test on iOS - seems like location, camera, voice memo do not work
| return ActionButton( | ||
| icon: ZetaIcons.audio, | ||
| onPressed: onSend != null ? () => _onClick(context) : null, | ||
| semanticLabel: 'record a voice memo', |
Collaborator
There was a problem hiding this comment.
this should be a parameter passed into the widget
packages/zeta_flutter/lib/src/components/message_input/message_input.dart
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions include:
Photo attachmentVideo attachment