Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes two inline explanatory comments in setFightPlayer, leaving the functional behavior unchanged.
Changes:
- Deleted a comment about restoring combat hitboxes before re-enabling entity collision.
- Deleted a comment about clearing invulnerability frames (no corresponding logic exists here).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yow-sef
approved these changes
Apr 28, 2026
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| gui.remove(entry.getKey()); | ||
| for (Player player : inGuiPlayers.keySet()) { | ||
| if (inGuiPlayers.get(player) == entry.getKey()) { |
| private final Map<Integer, NormalLadder> ladderSlots = new HashMap<>(); | ||
| private final int spaces = 45; | ||
| private final Map<Integer, Map<Integer, NormalLadder>> ladderSlots = new HashMap<>(); | ||
| private final Map<Player, Integer> backToPage = new HashMap<>(); |
| }; | ||
| inventory = splitInventory; | ||
| } | ||
| private Map<Integer, CustomKit> loadCustomKitSet(NormalLadder ladder, String name, String type) { |
|
|
||
| private static boolean executeWriteWithRetry(String operation, SqlWriteOperation writeOperation) { | ||
| int attempt = 1; | ||
| while (attempt <= RETRYABLE_WRITE_MAX_ATTEMPTS) { |
| 13, | ||
| ConfigManager.getString("EVENT.BRACKETS.NAME"), | ||
| ItemCreateUtil.createItem("&aBrackets", Material.POTION, Short.valueOf("34")), | ||
| ItemCreateUtil.createItem("<green>Brackets", Material.POTION, Short.valueOf("34")), |
* fix: fix profile worldtime default value and handle offline players in leaderboards * fix: resolve party chat permission error caused by missing break * fix: not-won round symbols rendering as filled on scoreboard * Prevent throwing ender peal if cooldown is 0.0 in the start of the match * fix: shade MariaDB driver to prevent classpath conflict with other plugins * fix: remove players from live match on rejoin if they disconnected during duel acceptance * Refactor Profile * Refactor Profile * Fix for #536 * Full MiniMessage support * hex/legacy color code support * add missing ladder * Fix sidebar
…rvation on ladder disable
…mline cooldown handling
| try (InputStream in = practice.getResource("config.yml")) { | ||
| if (in == null) return Collections.emptyMap(); | ||
| bundled = new YamlConfiguration(); | ||
| bundled.load(new InputStreamReader(in)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.