Skip to content

fix: not-won round symbols rendering as filled on scoreboard #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nandi0813 merged 6 commits into from
May 18, 2026
Merged

fix: not-won round symbols rendering as filled on scoreboard #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da1639f
fix: fix profile worldtime default value and handle offline players i…
lokspel May 18, 2026
8f035e8
Merge branch 'ZoneDevelopement:dev' into dev
lokspel May 18, 2026
6dcf467
fix: resolve party chat permission error caused by missing break
lokspel May 18, 2026
0490640
Merge remote-tracking branch 'origin/dev' into dev
lokspel May 18, 2026
8711fed
Merge branch 'ZoneDevelopement:dev' into dev
lokspel May 18, 2026
1fa95c3
fix: not-won round symbols rendering as filled on scoreboard
lokspel May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/dev/nandi0813/practice/manager/fight/match/type/duel/Duel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;

@Getter
public class Duel extends Match implements Team {
Expand Down Expand Up @@ -108,9 +109,11 @@ public DuelRound getCurrentRound() {

@Override
public int getWonRounds(Player player) {
UUID playerUuid = player.getUniqueId();
int wonRounds = 0;
for (Round round : this.rounds.values()) {
if (((DuelRound) round).getRoundWinner() == player)
Player winner = ((DuelRound) round).getRoundWinner();
if (winner != null && winner.getUniqueId().equals(playerUuid))
wonRounds++;
}
return wonRounds;
Expand Down
7 changes: 2 additions & 5 deletions core/src/main/java/dev/nandi0813/practice/manager/sidebar/adapter/AdapterUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,20 +154,17 @@ public static Component getRoundString(int rounds, int wonRounds, Component wonC
}

Component component = Component.empty();
boolean firstNotWon = true;
String roundSymbol = getRoundSymbol();
Component wonSymbol = wonColor == null
? Component.text(roundSymbol)
: wonColor.append(Component.text(roundSymbol));
Component notWonSymbol = Component.text(roundSymbol, NamedTextColor.GRAY);

for (int i = 1; i <= rounds; i++) {
if (i <= clampedWonRounds) {
component = component.append(wonSymbol);
} else if (firstNotWon) {
component = component.append(Component.text(roundSymbol, NamedTextColor.GRAY));
firstNotWon = false;
} else {
component = component.append(Component.text(roundSymbol));
component = component.append(notWonSymbol);
}
}

Expand Down