Merged
Conversation
SamTebbs33
force-pushed
the
feature/phys-mem-manager
branch
2 times, most recently
from
28bef64 to
572b504
Compare
SamTebbs33
force-pushed
the
feature/phys-mem-manager
branch
2 times, most recently
from
afb8c9f to
9551107
Compare
SamTebbs33
force-pushed
the
feature/phys-mem-manager
branch
from
9551107 to
7a8d15f
Compare
Collaborator
Author
|
I reckon this is finally ready for review! @DrDeano |
DrDeano
reviewed
Dec 22, 2019
Member
|
As a side, could the pmm implement the Allocater interface |
Collaborator
Author
What is the advantage of it being an Allocator? |
Collaborator
Author
Discussed offline, will implement :+1 |
SamTebbs33
force-pushed
the
feature/phys-mem-manager
branch
2 times, most recently
from
b4b3f6b to
00153cf
Compare
DrDeano
reviewed
Jan 7, 2020
src/kernel/bitmap.zig
Outdated
| bitmaps: []BitmapType, | ||
|
|
||
| pub fn init(num_entries: u32, allocator: *std.mem.Allocator) !Self { | ||
| const num = num_entries / ENTRIES_PER_BITMAP + @boolToInt(num_entries % ENTRIES_PER_BITMAP != 0); |
Member
There was a problem hiding this comment.
I think @round is better. So can have @round(num_entries / @as(f32, ENTRIES_PER_BITMAP)) I assume num_entries will be implicitly cased.
DrDeano
reviewed
Jan 8, 2020
Member
DrDeano
left a comment
DrDeano
left a comment
There was a problem hiding this comment.
Still missing some comments from the previous feedback. But looking good :)
DrDeano
approved these changes
Jan 9, 2020
SamTebbs33
force-pushed
the
feature/phys-mem-manager
branch
from
e2b9fd7 to
7043ccd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a physical memory manager that keeps track of which physical blocks are used. It parses the multiboot memory map for reserved memory and sets the memory used by kernel code as occupied. Closes #67