Conversation
SamTebbs33
reviewed
Jan 9, 2020
Collaborator
SamTebbs33
left a comment
SamTebbs33
left a comment
There was a problem hiding this comment.
Nice changes. As well as making a windows build possible, the separation will mean people can tinker with the build process in a more familiar way. It's great to have i386 testing too.
SamTebbs33
reviewed
Jan 9, 2020
SamTebbs33
approved these changes
Jan 9, 2020
This also removed the need for `@intCase()` Also move the making directories and copying to a script to the build is simpler. Install qemu earler Added chmod +x Fixed copy elf Added missing switch for qemu binary Spelling Make makeiso.sh executable No longer chmod makeiso.sh Use the cache root to set the output directory
DrDeano
force-pushed
the
feature/unittest-in-build-arch
branch
from
11b2d33 to
0746048
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also change the build process to abstract out the Linux part of the building. This will later help with the native Windows build.
Closes #102