Merged
Conversation
SamTebbs33
requested changes
May 6, 2020
Collaborator
SamTebbs33
left a comment
SamTebbs33
left a comment
There was a problem hiding this comment.
Nice. In the future we could interpret the error code, eip and cr2 to give a human readable description of what went wrong.
Moved CR assembly to arch file Fixed new line Moved control registers from arch to paging
DrDeano
force-pushed
the
feature/log-cpu-state-on-page-fault
branch
from
367457d to
16b07bf
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page fault occurs, will log the CPU state and the control registers.