Skip to content

Make serial dependent on architecture#157

Merged
SamTebbs33 merged 1 commit intodevelopfrom
feature/abstract-serial
Jun 7, 2020
Merged

Make serial dependent on architecture#157
SamTebbs33 merged 1 commit intodevelopfrom
feature/abstract-serial

Conversation

@SamTebbs33
Copy link
Collaborator

Closes #156

Copy link
Member

@DrDeano DrDeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring ideas, but not sure.

Copy link
Member

@DrDeano DrDeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping it as is, is good, but a few more ideas :P

Copy link
Member

@DrDeano DrDeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SamTebbs33 SamTebbs33 force-pushed the feature/abstract-serial branch from fbca3bd to ecc3de4 Compare June 7, 2020 16:38
@SamTebbs33 SamTebbs33 merged commit 4f7e7a7 into develop Jun 7, 2020
@SamTebbs33 SamTebbs33 deleted the feature/abstract-serial branch June 7, 2020 16:41
@SamTebbs33 SamTebbs33 mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make serial implementation dependent on the architecture

2 participants