Merged
Conversation
SamTebbs33
force-pushed
the
feature/serial-init-payload
branch
2 times, most recently
from
989cdd3 to
cc48ec1
Compare
DrDeano
reviewed
Jun 9, 2020
src/kernel/arch/x86/arch.zig
Outdated
| /// The Serial instance constructed with the function used to write bytes | ||
| /// | ||
| pub fn initSerial() Serial { | ||
| pub fn initSerial(payload: BootPayload) Serial { |
Member
There was a problem hiding this comment.
Maybe could have the name the same in kamin: boot_payload
Member
There was a problem hiding this comment.
You missed the other 2 files :P
Collaborator
Author
There was a problem hiding this comment.
Oh I didn't know there were more lines to change
SamTebbs33
force-pushed
the
feature/serial-init-payload
branch
from
9192169 to
5101990
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158