Use the standardTargetOptions for built targets#168
Merged
Conversation
SamTebbs33
requested changes
Jun 20, 2020
Collaborator
SamTebbs33
left a comment
SamTebbs33
left a comment
There was a problem hiding this comment.
Don't forget to update the README. What do we pass to the option for it to build x86_i686 (if we want to specify it explicitly)?
SamTebbs33
approved these changes
Jun 20, 2020
DrDeano
force-pushed
the
feature/add-standardTargetOptions
branch
from
9c27321 to
e9be4ed
Compare
This will allow the user to build the OS with more fine grain, but there is a white list of supported build targets. Closes #129 Updated the README to reflect the new build options x86 => i386
DrDeano
force-pushed
the
feature/add-standardTargetOptions
branch
from
e9be4ed to
1b32fd3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the user to build the OS with more fine grain, but there is a white list of supported build targets.
Closes #129